[release-4.17] OCPBUGS-45964: performanceprofile cpuset input validation #1247
Conversation
This fix ensures that the input for any CPU set field is valid. If an invalid string that does not represent a valid CPU set is provided, the admission webhook will return an appropriate error, such as: spec.cpu: Internal error: strconv.Atoi: parsing "garbage": invalid syntax This replaces the previous behavior where the server would return an error like: Error from server: error when creating "pp.yaml": admission webhook "vwb.performance.openshift.io" denied the request: panic: runtime error: invalid memory address or nil pointer dereference [recovered]. Signed-off-by: Ronny Baturov <[email protected]>
Fuzz test for ValidateCPUs to verify it handles both valid and invalid inputs without panicking. This ensures that all potential errors are exercised and no panic occurs during execution. Signed-off-by: Ronny Baturov <[email protected]>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-45616 has been cloned as Jira Issue OCPBUGS-45964. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45964, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -217,6 +217,19 @@ var _ = Describe("PerformanceProfile", func() { | |||
| Expect(errors).NotTo(BeEmpty(), "should have validation error when isolated and shared CPUs have overlap") | |||
| Expect(errors[0].Error()).To(Or(ContainSubstring("isolated and shared cpus overlap"), ContainSubstring("shared and isolated cpus overlap"))) | |||
| }) | |||
| DescribeTable("should reject invalid input that does not represent CPU sets", | |||
| func(fieldSetter func(*PerformanceProfile, CPUSet), cpusField string) { | |||
There was a problem hiding this comment.
ok, this is a backport, but still: are we guaranteed mutations made by each table item does not leak to other items?
e.g. are items fully isolated from each other?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/jira refresh |
|
@yanirq: This pull request references Jira Issue OCPBUGS-45964, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@rbaturov: This pull request references Jira Issue OCPBUGS-45964, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/cherry-pick-approved |
|
/label cherry-pick-approved |
|
@rshemtov13: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label cherry-pick-approved |
|
@yanirq: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8d67253
into
openshift:release-4.17
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-45964: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-45964 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: new pull request created: #1264 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
This is an automated cherry-pick of #1239
/assign rbaturov
/cherrypick release-4.16