-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46426: e2e: add irdma to module_blacklist kernel args #1249
OCPBUGS-46426: e2e: add irdma to module_blacklist kernel args #1249
Conversation
Skipping CI for Draft Pull Request. |
/test all |
/test ci/prow/e2e-hypershift-pao ci/prow/e2e-hypershift |
@rbaturov: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-hypershift e2e-hypershift-pao |
d91375e
to
905b130
Compare
@rbaturov: This pull request references Jira Issue OCPBUGS-46426, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
905b130
to
f700e48
Compare
/test e2e-hypershift |
This implements a workaround to prevent CI failures on specific hardware using an Intel E810 network card. When UserLevelNetworking is set to True, tuned attempts to set the combined channel count equal to the reserved CPUs but fails with the following error: tuned.utils.commands: Executing 'ethtool -L ens2f0 combined 1' error: netlink error: Device or resource busy The error occurs because the ice driver: ens2f0: Cannot change channels when RDMA is active. This issue causes the tuned profile to degrade. As a temporary solution, by adding 'module_blacklist=irdma' to the kernel Args we will block RDMA, to avoid these errors. Reference: OCPBUGS-46426 Signed-off-by: Ronny Baturov <[email protected]>
f700e48
to
a2678de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a minor nit, what is the impact of blacklisting module_blacklist=irdma
and do we really need/want this? I believe, at a minimum, we probably want to state what the impact is in the commit log.
OK, this is just e2e tests. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, rbaturov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
/unhold |
/cherry-pick release-4.18 release-4.17 release-4.16 |
@rbaturov: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@rbaturov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
c0171d3
into
openshift:master
@rbaturov: Jira Issue OCPBUGS-46426: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46426 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rbaturov: new pull request created: #1257 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
This implements a workaround to prevent CI failures on specific hardware using an Intel E810 network card.
When UserLevelNetworking is set to True, tuned attempts to set the combined channel count equal to the reserved CPUs but fails with the following error:
tuned.utils.commands: Executing 'ethtool -L ens2f0 combined 1' error: netlink error: Device or resource busy
The error occurs because the ice driver: ens2f0: Cannot change channels when RDMA is active.
This issue causes the tuned profile to degrade.
As a temporary solution, by adding 'module_blacklist=irdma' to the kernel Args we will block RDMA, to avoid these errors.