e2etests, allow camo CSV checks to tolerate 1 transient failed request. #451
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nephomaniac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 65.82% 65.82%
=======================================
Files 8 8
Lines 916 916
=======================================
Hits 603 603
Misses 290 290
Partials 23 23 🚀 New features to boost your workflow:
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
nephomaniac
force-pushed
the
e2ecsvretry
branch
from
2c7d907 to
b053591
Compare
|
@nephomaniac: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR attempts to allow e2e tests to tolerate a maximum number of CAMO CSV (Clusterserviceversions) request failures greater than 0 during the period where the test is waiting for the CAMO CSV to become present and phase status 'Succeeded'. This is intended to help the tests continue during normal/transient states of the CAMO CSV/cluster (ie such as upgrades).
CSV request failures will be both logged and counted. Once the max allowed number of CSV request failures is met, future request errors will be handled with the previous Expect() cases which will then abort the test.
If the number of CSV request errors does not exceed the allowed maximum, the check continues to loop every ~30 seconds checking the phase of the CAMO CSV.
This PR also logs the elapsed time for each iteration of the CSV check.
These changes have been tested locally against a cluster w/ and w/o the camo CSV present, and with the CSV in phases 'Pending' and 'Succeeded'. Local execution...