Skip to content

e2etests, allow camo CSV checks to tolerate 1 transient failed request. #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

e2etests, allow camo CSV checks to tolerate 1 transient failed request. #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions test/e2e/configure_alertmanager_operator_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package osde2etests

import (
"context"
"fmt"
"time"

"github.com/onsi/ginkgo/v2"
Expand Down Expand Up @@ -33,6 +34,7 @@ var _ = Describe("Configure AlertManager Operator", Ordered, func() {
serviceAccounts = []string{"configure-alertmanager-operator"}
)
const (
maxCSVFailures = 1 //number of csv request failures before exiting
timeoutDuration = 300 * time.Second
pollingDuration = 30 * time.Second
configMapLockFile = "configure-alertmanager-operator-lock"
Expand All @@ -50,21 +52,45 @@ var _ = Describe("Configure AlertManager Operator", Ordered, func() {
dynamicClient, err = dynamic.NewForConfig(cfg)
Expect(err).ShouldNot(HaveOccurred(), "failed to configure Dynamic client")
})

// Allow for one CSV request failure before exiting Eventually() loop...
csvErrCounter := 0
startCSVCheck := time.Now()
It("cluster service version exists", func(ctx context.Context) {
Eventually(func(ctx context.Context) bool {
elapsed := fmt.Sprintf("%f", time.Since(startCSVCheck).Seconds())
GinkgoLogr.Info("CAMO CSV check", "secondsElapsed", elapsed)
csvList, err := dynamicClient.Resource(
schema.GroupVersionResource{
Group: "operators.coreos.com",
Version: "v1alpha1",
Resource: "clusterserviceversions",
},
).Namespace(namespace).List(ctx, metav1.ListOptions{LabelSelector: labelSelector})
Expect(err).NotTo(HaveOccurred(), "Failed to retrieve CSV from namespace %s", namespace)
Expect(csvList.Items).Should(HaveLen(1))

if csvErrCounter >= maxCSVFailures {
// If maxCSVFailures has been exceeded, handle errors with Expect()...
csvErrCounter++
GinkgoLogr.Error(err, fmt.Sprintf("CSV error counter: %d, tolerated errors: %d", csvErrCounter, maxCSVFailures))
Expect(err).NotTo(HaveOccurred(), "Failed to retrieve CSV from namespace %s", namespace)
Expect(csvList.Items).Should(HaveLen(1))
}
if err != nil {
GinkgoLogr.Error(err, fmt.Sprintf("Err, fetching CSV for NS:'%s' LABEL:'%s'", namespace, labelSelector))
csvErrCounter++
return false
}
if csvList == nil {
GinkgoLogr.Error(nil, fmt.Sprintf("Err, nil CSV list fetching CSV for NS:'%s' LABEL:'%s'", namespace, labelSelector))
csvErrCounter++
return false
}
if len(csvList.Items) != 1 {
GinkgoLogr.Error(nil, fmt.Sprintf("Err, expected 1 CSV for NS:'%s' LABEL:'%s'. Got %d", namespace, labelSelector, len(csvList.Items)))
csvErrCounter++
return false
}
statusPhase, _, _ := unstructured.NestedFieldCopy(csvList.Items[0].Object, "status", "phase")
if statusPhase == "Succeeded" {
GinkgoLogr.Info("csv phase", "phase", statusPhase)
return true
}
GinkgoLogr.Info("csv phase", "phase", statusPhase)
Expand Down