-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-jira: bump cluster-api version to 1.8.2 #9055
no-jira: bump cluster-api version to 1.8.2 #9055
Conversation
This is a fallout from openshift#9010. The cluster-api binary version used should be no lower than the greatest version required by the providers which in this case is 1.8.2 by ibmcloud. Otherwise, we will be running an older binary while linking the provider against a newer version, possibly requiring new function args and/or functions.
@r4f4: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @hamzy |
/assign @patrickdillon |
/test ? |
@r4f4: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-nutanix-ovn e2e-powervs-capi-ovn e2e-azure-ovn e2e-openstack-ovn e2e-vsphere-ovn |
nutanix and vsphere: e2e failures, so no issues with capi 1.8.2
|
/test e2e-powervs-capi-ovn |
So the powervs install finished. It seems we are good with capi 1.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ah, my bad. /approve Thanks for cleaning this up! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's easy to miss. I've added a card in our tech debt epic to add a check for that in our presubmit tests. |
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/e2e-gcp-ovn |
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
daa6fb9
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
This is a fallout from #9010.
The cluster-api binary version used should be no lower than the greatest version required by the providers which in this case is 1.8.2 by ibmcloud. Otherwise, we will be running an older binary while linking the provider against a newer version, possibly requiring new function args and/or functions.