structured logging2 #488
structured logging2 #488
Conversation
|
Hi @pinikomarov. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pinikomarov
force-pushed
the
structured_logging2
branch
from
46e8ee9 to
523d07d
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c23489d601fd4e428c03961f23ebb336 ❌ openstack-k8s-operators-content-provider FAILURE in 5m 21s |
|
/ok-to-test |
|
recheck |
pinikomarov
force-pushed
the
structured_logging2
branch
from
523d07d to
de36266
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
pinikomarov
force-pushed
the
structured_logging2
branch
from
de36266 to
b56f954
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
pinikomarov
force-pushed
the
structured_logging2
branch
from
b56f954 to
464ddd2
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/257d4f263ec1408680dbd523d63b30e3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 01s |
pinikomarov
force-pushed
the
structured_logging2
branch
from
3698019 to
c4a5391
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
pinikomarov
force-pushed
the
structured_logging2
branch
from
c4a5391 to
e2aafb6
Compare
pinikomarov
force-pushed
the
structured_logging2
branch
from
e2aafb6 to
1b63269
Compare
pinikomarov
force-pushed
the
structured_logging2
branch
from
8d0daa7 to
781ce1b
Compare
Sure , thanks , updated the commit message |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0aef5a4746a94c53af4a16d330874fbc ❌ openstack-k8s-operators-content-provider FAILURE in 7m 51s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/d03830988f634634a0a984fa618742dd ❌ openstack-k8s-operators-content-provider FAILURE in 7m 56s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ee44e550b69b48e59b3072b285ec5c63 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 12s |
slagle
force-pushed
the
structured_logging2
branch
from
58ebbb7 to
61642e4
Compare
|
@pinikomarov I pushed to your fork in order to resolve the conflicts. Let's see if it passes CI now, than we can move forward with merging it. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/eb7251379c6f49beaeded8ff6d32d7da ❌ openstack-k8s-operators-content-provider FAILURE in 7m 43s |
slagle
force-pushed
the
structured_logging2
branch
from
61642e4 to
b97a04d
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/47975750dc2d4e47ba5df590768bb13e ❌ openstack-k8s-operators-content-provider FAILURE in 7m 14s |
This automatically adds additional fields like reconcile_id etc.. from the controller context.
and standardize the logging implementation
example logging after patch:
```
2023-10-24T17:30:11+03:00 INFO Controllers.OpenStackDataPlaneNodeSet Reconciling DNSData {"controller": "openstackdatapla
nenodeset", "controllerGroup": "dataplane.openstack.org", "controllerKind": "OpenStackDataPlaneNodeSet", "OpenStackDataPlaneNodeSet": {"
name":"openstack-edpm","namespace":"openstack"}, "namespace": "openstack", "name": "openstack-edpm", "reconcileID": "28cdfd8a-e595-415b-b20b-89b6da5f16e0", "ObjectType": "*v1beta1.OpenStackDataPlaneNodeSet", "ObjectNamespace": "openstack", "ObjectName": "openstack-edpm"}
```
*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.
slagle
force-pushed
the
structured_logging2
branch
from
b97a04d to
5a07a2f
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e633c5c0095a4c32ba936ed8fa8f6bf6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 17s |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ff0e1709c4d641efa074023ba8466a26 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 56s |
slagle
force-pushed
the
structured_logging2
branch
from
2ff7097 to
47f0631
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pinikomarov, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 66f0027
into
openstack-k8s-operators:main
This automatically adds additional fields like reconcile_id etc.. from the controller context.
and standardize the logging implementation
example logging after patch:
*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.