Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the network names case insensitive #169

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jan 22, 2024

This could be a temporary change to make dataplane networks small case and align with what we use in
control plane network attachments etc or permanent if we want to make networks/subnets case in-sensitive.

@openshift-ci openshift-ci bot requested review from abays and lewisdenny January 22, 2024 09:37
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/70f13bedd5c644b29b5399ed411c06b7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 56s
podified-multinode-edpm-deployment-crc FAILURE in 23m 14s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 15m 15s

@rabi
Copy link
Contributor Author

rabi commented Jan 22, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ebf823be0b6148d0a796a2d98527273a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 06s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 18s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 15m 47s

@rabi
Copy link
Contributor Author

rabi commented Jan 23, 2024

/test infra-operator-build-deploy-kuttl

@rabi
Copy link
Contributor Author

rabi commented Jan 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8d3cc13251144703869a919a21da8334

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 41s
podified-multinode-edpm-deployment-crc FAILURE in 41m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 40s

@rabi
Copy link
Contributor Author

rabi commented Jan 23, 2024

multinode job failed with error: unable to default to a user name: the server is currently unable to handle the request (get users.user.openshift.io ~

@rabi
Copy link
Contributor Author

rabi commented Jan 23, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 23, 2024

/test infra-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/109a2d8a13774d2b91b63974a56252ff

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 40s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 16m 02s

@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

/test infra-operator-build-deploy-kuttl

1 similar comment
@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

/test infra-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ef76b3164edf497abf4584b671308b77

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 41s
podified-multinode-edpm-deployment-crc FAILURE in 24m 33s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 15m 38s

@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

/test infra-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/75a9c77bc96146ddb46fead4d9014c82

✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 25s
podified-multinode-edpm-deployment-crc FAILURE in 21m 57s
cifmw-crc-podified-edpm-baremetal FAILURE in 39m 18s

@rabi
Copy link
Contributor Author

rabi commented Jan 25, 2024

recheck

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rabi
Copy link
Contributor Author

rabi commented Jan 26, 2024

/test infra-operator-build-deploy-kuttl

1 similar comment
@rabi
Copy link
Contributor Author

rabi commented Jan 29, 2024

/test infra-operator-build-deploy-kuttl

@rabi
Copy link
Contributor Author

rabi commented Jan 29, 2024

Looks like failing building bundle.

[2/3] STEP 7/8: RUN /workspace/csv-merger --import-env-files=/bundle_extra_data/env-vars.yaml --dataplane-csv=/bundle_extra_data/manifests/dataplane-operator.clusterserviceversion.yaml --base-csv=/manifests/openstack-operator.clusterserviceversion.yaml | tee /openstack-operator.clusterserviceversion.yaml.new
open /bundle_extra_data/env-vars.yaml: no such file or directorygoroutine 1 [running]:
runtime/debug.Stack()
/usr/local/go/src/runtime/debug/stack.go:24 +0x65
runtime/debug.PrintStack()
/usr/local/go/src/runtime/debug/stack.go:16 +0x19
main.exitWithError({0xc00047a900?, 0xe713fb?})
/workspace/csv-merger.go:71 +0x33
main.getEnvsFromFile({0x7fff5374ae51?, 0x20?})
/workspace/csv-merger.go:41 +0x47
main.main()
/workspace/csv-merger.go:165 +0x650

This could be a temporary change to make dataplane
networks small case and align with what we use in
control plane network attachments etc or permanent
if we want to make networks/subnets case in-sensitive.

Signed-off-by: rabi <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jan 29, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d246bac41f7e4cd38e97feeb75d55156

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 09s
podified-multinode-edpm-deployment-crc FAILURE in 56m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 08m 05s

@rabi
Copy link
Contributor Author

rabi commented Jan 29, 2024

recheck tempest failed with neutron not available

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a18f61f2e0fd404fbb62492ed92a5469

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 37s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 24s

@rabi
Copy link
Contributor Author

rabi commented Jan 30, 2024

/retest

@rabi
Copy link
Contributor Author

rabi commented Jan 30, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a6b8d765da154270ae1ed84f3c2cd8f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 24s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 19s

@rabi
Copy link
Contributor Author

rabi commented Jan 30, 2024

let's see if removing depends-on helps.. I can't see why it should fail.

@rabi
Copy link
Contributor Author

rabi commented Jan 30, 2024

/test infra-operator-build-deploy-kuttl

@rabi
Copy link
Contributor Author

rabi commented Jan 30, 2024

recheck

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b385d2c into openstack-k8s-operators:main Jan 30, 2024
7 checks passed
SeanMooney added a commit to SeanMooney/dataplane-operator that referenced this pull request Jan 30, 2024
openstack-k8s-operators/infra-operator#169
changed the names in the netconfig sample to be lower case.
it should have made the infra operator case insensitive
however it does not appear to be working.

This change updates the samples to be lowercase to workaround that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants