Update placementapi to use service override

[stuggi]

Removes creation of routes. Those get done in the openstack-operator. Via service overrides the service can be customized. The service operator adds annotation to the service which needs to be exposed as a route.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#332
Depends-On: openstack-k8s-operators/keystone-operator#307

[stuggi]

/hold

[gibizer]

The kuttl test failed on the service labels it seems there was some changes there. Is this intentional?

    case.go:366: --- Service:placement-kuttl-tests/placement-internal
        +++ Service:placement-kuttl-tests/placement-internal
        @@ -1,15 +1,70 @@
         apiVersion: v1
         kind: Service
         metadata:
        +  annotations:
        +    core.openstack.org/ingress_create: "false"
        +    endpoint: internal
           labels:
        -    internal: "true"
        +    endpoint: internal
             service: placement

case.go:366: --- Service:placement-kuttl-tests/placement-public
        +++ Service:placement-kuttl-tests/placement-public
        @@ -1,15 +1,70 @@
         apiVersion: v1
         kind: Service
         metadata:
        +  annotations:
        +    core.openstack.org/ingress_create: "true"
        +    endpoint: public
           labels:
        -    public: "true"
        +    endpoint: public
             service: placement

[stuggi]

The kuttl test failed on the service labels it seems there was some changes there. Is this intentional?

    case.go:366: --- Service:placement-kuttl-tests/placement-internal
        +++ Service:placement-kuttl-tests/placement-internal
        @@ -1,15 +1,70 @@
         apiVersion: v1
         kind: Service
         metadata:
        +  annotations:
        +    core.openstack.org/ingress_create: "false"
        +    endpoint: internal
           labels:
        -    internal: "true"
        +    endpoint: internal
             service: placement

case.go:366: --- Service:placement-kuttl-tests/placement-public
        +++ Service:placement-kuttl-tests/placement-public
        @@ -1,15 +1,70 @@
         apiVersion: v1
         kind: Service
         metadata:
        +  annotations:
        +    core.openstack.org/ingress_create: "true"
        +    endpoint: public
           labels:
        -    public: "true"
        +    endpoint: public
             service: placement

yes, that was intentional. I have to update the kuttl tests. waiting for the infra-operator and keystone-operator PR to land. Then I'll update the other operators

[gibizer]

Looks good to me. Special thanks for adding envtest coverage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gibizer,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stuggi]

/unhold

[bogdando]

nit: please add "No configMaps for scripts and service configs"