Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default effective_io_concurrency and random_page_cost to SSD values #613

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Sep 11, 2023

Since all drives are SSDs in arrays with at least two drives, 256 is a reasonable default. NVMe drives could have this set even higher, but this is a reasonable start.

@tomhughes
Copy link
Member

So far we've stuck with keeping the defaults equal to the upstream defaults and only overriding them as needed but I guess we don't have to.

@pnorman
Copy link
Collaborator Author

pnorman commented Sep 11, 2023

We've overridden this on all the nominatim machines and api DB servers, and I was about to do so for all the render servers, so I figure we might as well do it globally. Some defaults just aren't sensible on a server of reasonable capacity, since PostgreSQL aims for defaults that will work on a very small machine.

@tomhughes
Copy link
Member

Shouldn't this also remove the overrides that we already have in place then?

Since all the drives with DBs on them are SSDs, set these GUCs to values
more appropriate to a generic SSD. NVMe drives could have even higher
concurrency, but this is a reasonable start.
@pnorman pnorman force-pushed the effective_io_concurrency branch from 5e50da8 to 4018bab Compare September 12, 2023 09:13
@pnorman pnorman changed the title Set default effective_io_concurrency to 256 Set default effective_io_concurrency and random_page_cost to SSD values Sep 12, 2023
@pnorman
Copy link
Collaborator Author

pnorman commented Sep 12, 2023

I've removed the overrides that were 256 or near it. Nominatim has per-server specific overrides, so I left those in place. cc @lonvia

I also added random_page_cost since we were overwriting it on tile servers, all the api DB servers, and nominatim servers. I left the nominatim override in place, since that's been tuned to unusual values.

@tomhughes tomhughes merged commit 27dcb5b into openstreetmap:master Sep 12, 2023
@pnorman pnorman deleted the effective_io_concurrency branch September 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants