Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSDEV-1474] Add contributor type to /api/contributors/ endpoint #461

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

roman-stolar
Copy link
Contributor

@roman-stolar roman-stolar commented Dec 16, 2024

OSDEV-1474 Add contributor type to /api/contributors/ endpoint

  • Added contributor type value to response of /api/contributors/ endpoint
  • Updated unit test

@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 12:59 — with GitHub Actions Inactive
Copy link

coderabbitai bot commented Dec 16, 2024

Warning

Rate limit exceeded

@roman-stolar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b1ddf05 and ef48511.

📒 Files selected for processing (1)
  • src/django/api/views/contributor/all_contributors.py (1 hunks)
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

This pull request introduces several key updates to the Open Supply Hub project. The changes focus on improving the /api/contributors/ endpoint by adding a contributor type to the response, fixing date validation issues, and correcting country sorting in the backend. The modifications enhance data handling, API response clarity, and test coverage for contributor-related functionality. The release notes for version 1.27.0 highlight these improvements and provide guidance for post-deployment steps.

Changes

File Change Summary
doc/release/RELEASE-NOTES.md Updated with version 1.27.0 release details, including bug fixes and new features
src/django/api/tests/test_contributors_list_api_endpoint.py Added new contributor type variables and updated test methods to validate contributor types in API responses
src/django/api/views/contributor/all_contributors.py Modified response data to include contributor types, with logic to handle "Other" contributor types

Sequence Diagram

sequenceDiagram
    participant Client
    participant ContributorsAPI
    participant Database
    Client->>ContributorsAPI: Request /api/contributors/
    ContributorsAPI->>Database: Fetch Contributors
    Database-->>ContributorsAPI: Return Contributors with Types
    ContributorsAPI->>ContributorsAPI: Process Contributor Types
    ContributorsAPI-->>Client: Response with Contributor Details and Types
Loading

Possibly related PRs

Suggested reviewers

  • vladsha-dev
  • Innavin369
  • mazursasha1990

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 13:01 — with GitHub Actions Inactive
Copy link

barecheck bot commented Dec 16, 2024

React App | Jest test suite - Code coverage report

Total: 27.88%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@roman-stolar roman-stolar temporarily deployed to Quality Environment December 16, 2024 13:06 — with GitHub Actions Inactive
Copy link

barecheck bot commented Dec 16, 2024

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link

barecheck bot commented Dec 16, 2024

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link

barecheck bot commented Dec 16, 2024

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@mazursasha1990 mazursasha1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

@vladsha-dev vladsha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants