Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pending hotkey emission on swap #799

Merged

Conversation

camfairchild
Copy link
Contributor

Description

This hotfixes an issue with the hotkeyswap and the newPendingdHotkeyEmission maps.

Currently any hotkeys that swap will lose the pending hotkey emission, being recorded as an entry in the Stake map Stake(old_hotkey, 0x0000) (default AccountId).

This PR fixes the swap functions for coldkey and hotkey and adds a migration for two known hotkey swaps.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild changed the base branch from main to hotfix/patch-new-tempo-upgrade September 11, 2024 17:10
This reverts commit fb02f4a.
@unconst unconst merged commit 43e504c into hotfix/patch-new-tempo-upgrade Sep 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants