Hotfix/only exclude add stake from emission no packing #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00ad4bf.
…e-new-add-stake-from-emission
camfairchild
requested review from
distributedstatemachine and
garrett-opentensor
This was referenced Sep 12, 2024
camfairchild
added a commit
that referenced
this pull request
Sep 12, 2024
* add impl * add tests * add impl * chore: clippy * oops fix test * bump spec * add test from PR #805 * Revert "bump spec" This reverts commit 00ad4bf. * chore: fmt * remove lastaddstakeincrease logic * fix comment command * coinbase test with no deltas * add tests * renumber and remove * fix for childkey set weights * fix test for last commit * clippy: allow manual inspect * chore: fmt * add shebang * chore: clippy * move assert up * move clippy allow to toml * add fuzzy assert * fix neg delta test * Fix tests with correct take percent * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the same as #800 but removes the extra packing optim
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.