Fix comparison of feedId

[habrahamsson-skanetrafiken]

Summary

Change comparison of feedId in Triptimes to use .equals() instead of ==. In practice it doesn't cause any issues currently, but the current code is dangerous since anyone using this method will expect structural comparison.

Discussion:
There was some concern raised that the original code might use == for performance reasons. But for that case there is a method getTripTimes(Trip trip) that uses referential equality and then we could change the performance critical code to use that method instead.

Unit tests

Added a unit test to illustrate the issue.

Bumping the serialization version id

Nope

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.95%. Comparing base (b380134) to head (cef1fd5).

Files	Patch %	Lines
...main/java/org/opentripplanner/model/Timetable.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5857   +/-   ##
==========================================
  Coverage      67.95%   67.95%           
+ Complexity     16607    16606    -1     
==========================================
  Files           1914     1914           
  Lines          72648    72648           
  Branches        7452     7452           
==========================================
  Hits           49369    49369           
+ Misses         20749    20746    -3     
- Partials        2530     2533    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.