Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison of feedId #5857

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix comparison of feedId #5857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/opentripplanner/model/Timetable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public TripTimes getTripTimes(Trip trip) {

public TripTimes getTripTimes(FeedScopedId tripId) {
for (TripTimes tt : tripTimes) {
if (tt.getTrip().getId() == tripId) {
if (tt.getTrip().getId().equals(tripId)) {
return tt;
}
}
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/org/opentripplanner/model/TimetableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ public static void setUp() throws Exception {
trip_1_1_index = timetable.getTripIndex(new FeedScopedId(feedId, TRIP_ID));
}

@Test
public void getGetTripTimes() {
var tt = timetable.getTripTimes(new FeedScopedId(feedId, TRIP_ID));
assertNotNull(tt);
}

@Test
public void tripNotFoundInPattern() {
// non-existing trip
Expand Down
Loading