[PT FE] Add aten::rot90 #28224
Open
[PT FE] Add aten::rot90 #28224
+127
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvafin
requested changes
Dec 30, 2024
mvafin
requested changes
Jan 5, 2025
| ? context.mark_node(v0::Constant::create(element::i32, Shape{2}, {0,1})) | ||
| : get_input_as_i32(context, 2); | ||
| const auto& partial_shape = input.get_partial_shape(); | ||
| const auto ndims = partial_shape.rank().get_length(); |
There was a problem hiding this comment.
Please check that rank is static before get_length
Comment on lines
55
to
60
| if (const auto scatter_const = ov::util::get_constant_from_source(scatter)) { | ||
| scatter = context.mark_node(scatter_const); | ||
| } else { | ||
| context.mark_nodes( | ||
| {start, step, range, axis_0, dim0_node, dim1_node, indices, updates, scatter.get_node_shared_ptr()}); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (const auto scatter_const = ov::util::get_constant_from_source(scatter)) { | |
| scatter = context.mark_node(scatter_const); | |
| } else { | |
| context.mark_nodes( | |
| {start, step, range, axis_0, dim0_node, dim1_node, indices, updates, scatter.get_node_shared_ptr()}); | |
| } |
That is not that popular operation, no need for this optimization
mvafin
reviewed
Jan 8, 2025
|
|
||
| auto dims_norm = normalize_axis(context, dims, rank); | ||
| auto dims_const = std::dynamic_pointer_cast<v0::Constant>(dims_norm.get_node_shared_ptr()); | ||
| auto dims_values = dims_const->cast_vector<int32_t>(); |
There was a problem hiding this comment.
Now you only use dims_values only to validate that inputs are expected. That is nice to have, but not required and much better if we allow non-constant inputs then make these checks. So, please remove them. The only check that you can do is to verify that shape of dims is [2] or dynamic.
There was a problem hiding this comment.
I have removed the dims_values but I think there is some build errors in the pr request. Do i need to add anything if its dynamic ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: