Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JNML_HOME; test pulling image from dockerhub #333

Merged
merged 22 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-image-quickrun.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Build the Docker image
run: |
chmod a+w output/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Build the Docker image
run: |
chmod a+w output/
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/docker-pull.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Docker Pull Test

on:
push:
branches: [ master, dev* ]
pull_request:
branches: [ master, dev* ]

jobs:

build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Run the Docker image
run: |
# Don't build. Will be pulled when run below
./run.sh

- name: Info on Docker images
run: |
docker -v
docker images

- name: Run the Docker image - no c302
run: |
# Shouldn't need to pull again.
./stop.sh
./run-quick.sh

- name: Info on Docker images
run: |
docker -v
docker images

- name: Info on generated files
run: |
ls -alt
ls -alt output
ls -alt output/*
3 changes: 0 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ RUN git clone https://github.com/openworm/sibernetic.git && \
################################################################################
######## Set some paths//environment variables

ENV JNML_HOME=$HOME/jNeuroML
ENV PATH=$PATH:$JNML_HOME

ENV C302_HOME=$HOME/c302/c302
ENV SIBERNETIC_HOME=$HOME/sibernetic
ENV PYTHONPATH=$PYTHONPATH:$HOME/c302:$SIBERNETIC_HOME
Expand Down