Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on bitness of addition/subtraction in quantize/dequantize #1627

Closed
sdasgup3 opened this issue Jun 18, 2023 · 0 comments · Fixed by #2234
Closed

Decide on bitness of addition/subtraction in quantize/dequantize #1627

sdasgup3 opened this issue Jun 18, 2023 · 0 comments · Fixed by #2234
Assignees
@sdasgup3
Labels
Quantization Spec

Comments

@sdasgup3
Copy link
Member

As brought up in #1496 (comment), the current specification of the above ops obscures the type conversions involved during the corresponding computations. The ticket is about revisiting those specifications and attempt to clarify such details.
@sdasgup3 sdasgup3 added the Spec label Jun 18, 2023
@sdasgup3 sdasgup3 self-assigned this Jun 18, 2023
@sdasgup3 sdasgup3 mentioned this issue Jun 18, 2023
Merged
@burmako burmako changed the title Sharpen the specification of uniform_quantize and uniform_dequantize` Decide on bitness of addition/subtraction in quantize/dequantize Jun 19, 2023
@sdasgup3 sdasgup3 mentioned this issue Apr 18, 2024
Merged
sdasgup3 added a commit that referenced this issue May 1, 2024
@sdasgup3
Fix the bitness of addition/subtraction in quantize op (#2234)
1c91b78 
fixes #1627

Requesting the following for review:  
@loganchien
@paulinesho
@doyeonkim0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdasgup3 sdasgup3

Labels
Quantization Spec
Projects
Frontend contract
Status: Done
StableHLO v1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the bitness of addition/subtraction in quantize op sdasgup3/stablehlo
2 participants
@GleasonK @sdasgup3