-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification for UniformQuantizeOp and UniformDequantizeOp #1496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, which a few minor comments.
f8fcb10
to
e0ef8e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I think allowing also QuantizationIntegerScale should be discussed following that PR (#1475).
@dominicsymes
That is right. Once we have #1475 landed, then the quantize/dequantize op will allow that type too. |
e0ef8e3
to
340f968
Compare
340f968
to
03f1a16
Compare
eb3de74
to
52a5acf
Compare
My proposal is to merge the current PR and consider merging the two ops to convert op at a later point via #1576. |
cab2d62
to
e2d480a
Compare
As brought up [here](#1496 (comment)) that some parts of the `reference_checklist.md` are relevant enough to be included in the `spec_checklist.md`.
…y status of uniform.quantize, and some typos
…antize + following the reference checklist
e2d480a
to
93a6832
Compare
…antize and dequantize_compare
…antize and dequantize_compare
PiperOrigin-RevId: 543457854
PiperOrigin-RevId: 543457854
PiperOrigin-RevId: 543457854
…antize and dequantize_compare
fixes #531
fixes #530
Summary
The PR proposes the specification for
uniform.quantize
anduniform.dequantize
ops.The specification of
uniform.quantize
also captures the re-quantization conversions from quantized tensor to quantized tensors.Please let me know your feedback.
Working notes on following the
reference_checklist.md
andspec_checkilist.md
uniform_dequantize
We have the following constraints from the spec
These constraints will be comprehensively covered by the following tests:
If we drop the "Covered by ODS" pieces, this will leave us with the following test cases:
We already has a type inference test to cover the above.
uniform_quantize
We have the following constraints from the spec
These constraints will be comprehensively covered by the following tests:
If we drop the "Covered by ODS" pieces, this will leave us with the following test cases:
The above will be covered as part of #1603.