[cmake] Remove dependence on LLVM 'Core' component in the CMake build #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes two spurious 'LINK_COMPONENTS Core' declarations in the CMake build. Depending on the 'Core' component indicates that the libraries depend on the code under 'llvm-project/llvm/lib/IR' (e.g. 'LLVMCore' library), which is not true for the StablehloLinalgTransforms and StablehloTOSATransforms libraries.
christopherbate
force-pushed
the
remove-incorrect-llvm-core-dep
branch
from
19d5ed5
to
00e8114
Compare
sdasgup3
approved these changes
Sep 3, 2024
abhigunj
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes two spurious 'LINK_COMPONENTS Core' declarations in
the CMake build. Depending on the 'Core' component indicates that the
libraries depend on the code under 'llvm-project/llvm/lib/IR' (e.g. 'LLVMCore'
library), which is not true for the StablehloLinalgTransforms and
StablehloTOSATransforms libraries.