Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Version Syntax for PyTorch and PyTorch Lightning Examples #205

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update Version Syntax for PyTorch and PyTorch Lightning Examples #205

merged 4 commits into from
Oct 17, 2023

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Sep 29, 2023

Motivation

Fixes #204

Description of the changes

mpi4py
plotly
pytorch-ignite
-pytorch-lightning>=1.6.0
+pytorch-lightning>=2.0
skorch
-torch==1.11.0
+torch>=2.0
-torchvision==0.12.0
+torchvision>=0.12.0
-torchaudio==0.11.0
+torchaudio>=0.11.0
optuna

After installing PyTorch 2.0 and PyTorch Lightning 2.0, I ran pytorch_simple and pytorch_lightning_simple to confirm there were no issues with either example. Each ran without issue.

Additionally, I bumped the minimum Python version to 3.8 in pytorch.yml.

@jxtngx
Copy link
Contributor Author

jxtngx commented Sep 29, 2023

hello @c-bata @toshihikoyanase. my PR is ready for review.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I have a question about the reason why we need to drop the support for PyTorch lighitning v1.6 and Pytorch v1.11.

@@ -1,9 +1,9 @@
mpi4py
plotly
pytorch-ignite
pytorch-lightning>=1.6.0
pytorch-lightning>=2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, the pytorch lightning examples works with the latest version without changes, so I guess we can keep the support for v1.6 as well. Do we have difficulties to keep the the current lower bound?

Suggested change
pytorch-lightning>=2.0
pytorch-lightning>=1.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, there are no difficulties in keeping >=1.6 since that syntax logic will install whichever is the latest version.

Regarding explicitly setting a minimum at 2.0 in the requirements file, I would say this is more of a request as we move PL and Lightning Fabric into 2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment.

Taking your comments into account, I've reconsidered our approach. Up until now, we've only changed version constraints when code modifications required it.

On the other hand, the current CI only tests against the latest version as you mentioned, so we can't be certain that the lower version bounds are being accurately checked.

Therefore, rather than setting a lower limit, it might be more realistic to simply remove the version constraints and ensure functionality solely with the latest version.

What do you think of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me!

pytorch/requirements.txt Outdated Show resolved Hide resolved
pytorch/requirements.txt Outdated Show resolved Hide resolved
@toshihikoyanase toshihikoyanase self-assigned this Sep 30, 2023
Co-authored-by: Toshihiko Yanase <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Oct 8, 2023
@toshihikoyanase
Copy link
Member

Sorry for the delayed response. Let me check the update today.

@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Oct 10, 2023
Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update. Looks good to me.

@toshihikoyanase toshihikoyanase added this to the v3.5.0 milestone Oct 17, 2023
@toshihikoyanase toshihikoyanase merged commit 42d84c8 into optuna:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the PyTorch Lightning example to >= 2.0
2 participants