Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Version Syntax for PyTorch and PyTorch Lightning Examples #205

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Update Version Syntax for PyTorch and PyTorch Lightning Examples #205

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ec5b05
update version syntax
jxtngx Sep 29, 2023
2360245
update pytorch.yml
jxtngx Sep 29, 2023
eb722f8
Commit suggestion
jxtngx Sep 30, 2023
76e19b8
update requirements.txt
jxtngx Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytorch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v3
Expand Down
8 changes: 4 additions & 4 deletions pytorch/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
mpi4py
plotly
pytorch-ignite
pytorch-lightning>=1.6.0
pytorch-lightning>=2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my understanding, the pytorch lightning examples works with the latest version without changes, so I guess we can keep the support for v1.6 as well. Do we have difficulties to keep the the current lower bound?

Suggested change
pytorch-lightning>=2.0
pytorch-lightning>=1.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, there are no difficulties in keeping >=1.6 since that syntax logic will install whichever is the latest version.

Regarding explicitly setting a minimum at 2.0 in the requirements file, I would say this is more of a request as we move PL and Lightning Fabric into 2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment.

Taking your comments into account, I've reconsidered our approach. Up until now, we've only changed version constraints when code modifications required it.

On the other hand, the current CI only tests against the latest version as you mentioned, so we can't be certain that the lower version bounds are being accurately checked.

Therefore, rather than setting a lower limit, it might be more realistic to simply remove the version constraints and ensure functionality solely with the latest version.

What do you think of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me!

skorch
torch==1.11.0
torchvision==0.12.0
torchaudio==0.11.0
torch>=2.0
jxtngx marked this conversation as resolved.
Show resolved Hide resolved
torchvision>=0.12.0
torchaudio>=0.11.0
jxtngx marked this conversation as resolved.
Show resolved Hide resolved
optuna