Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import examples from optuna/optuna-dashboard #224

Merged

Conversation

toshihikoyanase
Copy link
Member

@toshihikoyanase toshihikoyanase commented Nov 7, 2023

Motivation

Currently, the examples for Optuna Dashboard are hosted in two different repository: this repository and optuna/optuna-dashboard. Unifying them would simplify discovery for users, as all examples would be accessible from a single location.

Description of the changes

  • Import dashboard examples from optuna/optuna-dashboard to ./dashboard
  • I'll create a subsequent PR to replace the example files in optuna/optuna-dashboard with links to the corresponding files in this repository.

Discussion

  • Should we preserve the commit history of the examples when importing them?

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, LGTM. This might be out of scope of this PR, but it would be better to add a README.md for these examples as a guide, IMO.

@toshihikoyanase
Copy link
Member Author

Thanks for your comment. I agree that adding a README file to ./dashboard would be beneficial for guiding users.
As you suggested, we can address this in subsequent PRs to maintain simplicity and clarity in our tracking history. Would that approach be okay with you?

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. LGTM.

@HideakiImamura HideakiImamura merged commit 99f83d5 into optuna:main Nov 10, 2023
7 checks passed
@toshihikoyanase toshihikoyanase deleted the import-optuna-dashboard-examples branch November 10, 2023 04:42
@HideakiImamura HideakiImamura added this to the v3.5.0 milestone Dec 8, 2023
@nabenabe0928 nabenabe0928 added the document Documentation related. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants