Import XFC as ES6 module #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kolkheang is this ready to be merged? |
kolkheang
reviewed
Sep 29, 2020
| @@ -4,9 +4,38 @@ In order to run any SMART app in Cerner's MPage view (iframe), the following pro | |||
|
|
|||
| This library uses [xfc](https://github.com/cerner/xfc) to solve [Clickjacking](https://www.owasp.org/index.php/Clickjacking) problem for all browsers. | |||
|
|
|||
| ## Availability | |||
| ## Installation | |||
|
|
|||
There was a problem hiding this comment.
Could you add a heading for NPM Module(Recommended)
README.md
Outdated
| }; | ||
| ``` | ||
|
|
||
| Warning: Disable XFC logging if using [F-Twelve](https://github.com/cerner/f-twelve/). F-Twelve writes to the DOM every time `console.log` is called and (when logging is enabled) XFC calls `console.log` every time the DOM is written to. This causes the browser to endlessly loop and freeze. It is safe to use both concurrently if XFC logging is disabled. |
There was a problem hiding this comment.
Perhaps bold the Warning: part
README.md
Outdated
| import 'cerner-smart-embeddable-lib'; | ||
| ``` | ||
|
|
||
| The minified & transpiled files are also available in the `dist/` directory and can be used with a `<script>` tag. |
There was a problem hiding this comment.
This could be under a new heading Script Include (NOT recommended) since you can't turn off XFC logging and it would conflict with MPages integration.
|
@pgross41 I just got a chance to review. Please let me know if the comments make sense. @shriniketsarkar could you take a look at this PR as well? |
|
@kolkheang made changes based on your comments please re-review |
kolkheang
approved these changes
Oct 2, 2020
|
@kolkheang is this ready to merge? |
shriniketsarkar
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26