Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for org.apache.commons:commons-dbcp2:2.9.0 #224

Closed
wants to merge 1 commit into from
Closed

Add support for org.apache.commons:commons-dbcp2:2.9.0 #224

wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Contributor

@linghengqian linghengqian commented Feb 8, 2023 •
edited
Loading

What does this PR do?

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

@linghengqian linghengqian mentioned this pull request Feb 8, 2023
Closed
7 tasks
@linghengqian linghengqian marked this pull request as ready for review February 8, 2023 16:44
@linghengqian linghengqian requested a review from a team as a code owner February 8, 2023 16:44
@linghengqian linghengqian requested a review from gradinac February 8, 2023 16:44
@linghengqian linghengqian force-pushed the apache-dbcp2 branch 2 times, most recently from 76ca968 to 5d08c45 Compare June 6, 2023 17:03
@linghengqian
Copy link
Contributor Author

@vjovanov
Copy link
Member

vjovanov commented Jun 7, 2023

@linghengqian there are a lot of tests in this PR. Did you write all of those tests, or they were copied from somewhere?

Also, is it possible to have the same coverage of metadata with fewer tests?

@linghengqian
Copy link
Contributor Author

@linghengqian there are a lot of tests in this PR. Did you write all of those tests, or they were copied from somewhere?

Also, is it possible to have the same coverage of metadata with fewer tests?

  • Most of the tests are adapted from DBCP2's documentation and Git repository, and avoid the unit test suite that GraalVM does not support.

  • I covered most of the use cases where reducing the size of the unit test may lead to a future issue that requires building a more complex unit test.

  • I assume you know which unit tests can be deleted directly? The unit tests here are considered before by the unit test rate.

wirthi
wirthi reviewed Jun 8, 2023
View reviewed changes
...ns-dbcp2/2.9.0/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including this file (and probably many of the others) is a copyright violation. It is copied from https://commons.apache.org/proper/commons-dbcp/xref-test/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.html which clearly is under Apache License. Neither can we simply copy this file without further approvals, nor - and this is an absolute no-go - can we change the license. @dnestoro @vjovanov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @wirthi Hi, I can do a massive rewrite of this PR with known test coverage. How about this proposal?

  • The Git of the DBCP ontology does not hook into the conditions of the Maven Plugin test of GraalVM Native Build Tools, because some tests are not compatible with GraalVM.

@linghengqian
Copy link
Contributor Author

  • Late reply as I am busy these months. I will refactor the contents of this PR as required by the master branch. Until the refactoring is complete, the PR will be in a draft state.

@linghengqian linghengqian marked this pull request as draft August 8, 2023 16:19
@linghengqian linghengqian mentioned this pull request Sep 4, 2023
Closed
6 tasks
linghengqian
linghengqian commented Sep 7, 2023
View reviewed changes
Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghengqian linghengqian deleted the apache-dbcp2 branch September 7, 2023 09:36
@dnestoro dnestoro mentioned this pull request Feb 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirthi wirthi wirthi left review comments

@gradinac gradinac Awaiting requested review from gradinac gradinac is a code owner automatically assigned from oracle/graalvm-reachability-maintainer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for org.apache.commons:commons-dbcp2:2.9.0
3 participants
@linghengqian @vjovanov @wirthi