-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for org.apache.commons:commons-dbcp2:2.9.0
#380
Conversation
...mons/commons-dbcp2/2.9.0/src/test/java/org_apache_commons/commons_dbcp2/CommonDbcp2Test.java
Outdated
Show resolved
Hide resolved
* You should have received a copy of the CC0 legalcode along with this | ||
* work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>. | ||
*/ | ||
package org_apache_commons.commons_dbcp2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests from this class require only the following metadata:
- reflect-config.json
[
{
"name":"org.apache.commons.dbcp2.PoolingDriver"
}
]
- resource-config.json
{
"bundles": [
{
"name": "org.apache.commons.dbcp2.LocalStrings"
}
]
}
So please modify metadata in the metadata/org.apache.commons/commons-dbcp2/2.9.0
folder or add more tests which would require other metadata.
Also I am not sure that org.apache.commons.dbcp2.PoolingDriver
should be added to the reflect-config.json
file in the main metadata directory since Class.forName("org.apache.commons.dbcp2.PoolingDriver");
is called in the test not in the commons-dbcp2
library itself, so that metadata entry should probably go to the tests/src/org.apache.commons/commons-dbcp2/2.9.0/src/test/resources/META-INF/native-image/dbcp2-test-only/reflect-config.json
file. @vjovanov - your thoughts?
b573662
to
a866db5
Compare
a866db5
to
20a846e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On the ShardingSphere side, the integration test for DBCP has been successfully moved from the main repository to https://github.com/apache/shardingsphere-plugin . PR and the corresponding issue are no longer meaningful.
What does this PR do?
org.apache.commons:commons-dbcp2:2.9.0
#202 .org.apache.commons:commons-dbcp2:2.9.0
#224.org.apache.commons:commons-dbcp2:2.9.0
.Code sections where the PR accesses files, network, docker or some external service
Checklist before merging