Add rust-sdk position test #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldragonfly
requested review from
yugure-orca,
wjthieme and
odcheung
as code owners
wjthieme
reviewed
Dec 20, 2024
| let ctx = RpcContext::new().await; | ||
|
|
||
| // Use token utility functions | ||
| let position_mint = setup_mint_with_decimals(&ctx, 0).await?; |
There was a problem hiding this comment.
You don't have to setup mint and ata when opening a position. The OpenPosition instruction will do that
| setup_ata_with_amount(&ctx, mint_b, 1_000_000_000).await?; | ||
|
|
||
| let whirlpool = setup_whirlpool(&ctx, mint_a, mint_b, 64).await?; | ||
| let position_pubkey = setup_position(whirlpool).await?; |
There was a problem hiding this comment.
Might be nice to add a position bundle and te_position as well to check if fetch_positions_for_owner finds those positions as well.
Same goes from the fetch_positions_in_pool test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Position and Position Bundle Test Coverage
Overview
Changes
setup_positionandsetup_position_bundlefor SPL and Token-2022.Notes
#[ignore]due to missinggetProgramAccountssupport in solana-bankrun.#[ignore]attributes.