t: Use consistent 'Mojo::Base' instead of strict+warnings #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalikiana
approved these changes
Dec 20, 2023
Martchus
approved these changes
Dec 20, 2023
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
okurz
force-pushed
the
feature/retry_git
branch
from
73c6fdf to
e2d97bd
Compare
|
ok, I think the problem is that in https://github.com/os-autoinst/os-autoinst-distri-openQA/actions/runs/7277050058/job/19828218115?pr=157#step:5:11 |
|
Yeah, I thought the same, see #158 |
|
@Mergifyio rebase |
Same as suggested in our documentation we should use Mojo::Base consistently in all openQA test modules.
✅ Branch has been successfully rebased |
okurz
force-pushed
the
feature/retry_git
branch
from
e2d97bd to
e4417b2
Compare
|
Now https://openqa.opensuse.org/tests/3831187#step/boot/4 fails, with the same error we see in our regular tests: https://openqa.opensuse.org/tests/3831958#step/boot/4 but which we aren't notified of because no emails :-/ |
|
https://progress.opensuse.org/issues/152889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as suggested in our documentation we should use Mojo::Base
consistently in all openQA test modules.
Motivated by: