-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using containers-storage even without --local #262
Conversation
I think we're all going to get stuck on the pull vs no-pull decision (i.e. whether we should behave like
In my mind, running bib is similar to a If I had to choose right now, I'd default to only pulling when |
My thinking is that we will probably want to adjust the behaviour of In other words, I'm absolutely fine with changing the behaviour, but once we know what the final behaviour should be. |
I think that pulling always is not the greatest idea since we switched to a container storage, but it keeps the backward compatibility. Note that the manifest test now has to be rootful because we run podman pull.
Right; If we always pulled it would break offline development, and we'd at least need a flag to not pull. Unfortunately there's not a |
I agree, Colin, and you can still achieve the same behaviour by using I know that we should unify the behaviour with |
Good call. Let's get this merged. |
Yep makes sense to me for the record! |
You could do a hack of podman run --pull=missing IMAGE true |
Or |
This pull request switches to using containers-storage even without the --local flag.