bib: respect the root fs type from the container #272
Conversation
I think that pulling always is not the greatest idea since we switched to a container storage, but it keeps the backward compatibility. Note that the manifest test now has to be rootful because we run podman pull.
Prior this commit, we always assumed that the root fs is ext4. However, it's possible to redefine this in the container, so let's respect this.
|
ftr, this needs tests and I also want to implement this properly in |
| // filesystem.root.type is the preferred way instead of the old root-fs-type top-level key. | ||
| // See https://github.com/containers/bootc/commit/558cd4b1d242467e0ffec77fb02b35166469dcc7 | ||
| fsType := bootcConfig.Filesystem.Root.Type | ||
| supportedFS := []string{"ext4", "xfs"} |
There was a problem hiding this comment.
I'm curious about the allowlist here; it seems distribution dependent at the minimum right? E.g. some distros/OSes use btrfs, there's also bcachefs coming in, etc.
Maybe it'd be better to have a denylist instead, i.e. not allow doing vfat for example. We could I guess do a sanity check that mkfs.$type exists in the root I guess to give a better error perhaps?
There was a problem hiding this comment.
I wonder if this is the right place for policy like this (i.e. I would rather just remove it). It seems to me the best place for this would be something like a "bootc lint" or "bootc build" that does checks. If we add the policy here we need to duplicate it accross bootc install to-disk and anaconda so having it in one central place seems more maintainable to me?
|
If we don't think we can land this type of thing somewhat in the near future, I think I'd advocate for making the default filesystem choice a configurable option when building the bib container image (i.e. building bib itself), as some OSes/distros will want to pick that default independently of this git repository. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This was moved to #383. |
Needs #262 or an alternative, this is mostly a showcase of how bib can be expanded after we can actually run the container.
Prior to this commit, we always assumed that the root fs is ext4. However, it's possible to redefine this in the container, so let's respect this.