Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib: check /var/lib/containers/storage when using "--local" (HMS-3792) #293

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Mar 20, 2024

Ensure to error early when the user is not passing the required

-v /var/lib/containers/storage:/var/lib/containers/storage

when doing a local build.

[edit: I looked again and the loop is so simple that I feel the integration test is enough]

@kingsleyzissou
Copy link
Contributor

So I tried something here 56ce13b n #259 😆 but this is probably more robust

@mvo5
Copy link
Collaborator Author

mvo5 commented Mar 20, 2024

So I tried something here 56ce13b n #259 😆 but this is probably more robust

Thanks! Yeah, the trouble is that this is always a mount point, with -v it will point to the host without it will be an overlayfs inside the container storage.

bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
test/test_manifest.py Outdated Show resolved Hide resolved
@mvo5 mvo5 marked this pull request as ready for review March 20, 2024 16:11
@mvo5 mvo5 force-pushed the err-on-volume-missing branch 2 times, most recently from 740c36b to 3b5722b Compare March 20, 2024 16:13
@mvo5 mvo5 requested a review from achilleas-k March 20, 2024 18:05
@ochosi ochosi changed the title bib: check /var/lib/containers/storage when using "--local" bib: check /var/lib/containers/storage when using "--local" (HMS-3792) Mar 21, 2024
kingsleyzissou
kingsleyzissou previously approved these changes Mar 21, 2024
@kingsleyzissou kingsleyzissou added this pull request to the merge queue Mar 21, 2024
@mvo5 mvo5 removed this pull request from the merge queue due to a manual request Mar 21, 2024
Ensure to error early when the user is not passing the required
```
-v /var/lib/containers/storage:/var/lib/containers/storage
```
when doing a local build.
@mvo5 mvo5 enabled auto-merge March 21, 2024 11:56
@mvo5 mvo5 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into osbuild:main with commit 7f770db Mar 21, 2024
6 of 9 checks passed
@mvo5 mvo5 deleted the err-on-volume-missing branch March 21, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants