clienterrors: rename WorkerClientError to clienterrors.New
#4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
@mvo5 do you mind if I push to your branch with the rebase? |
The usual convention to create new object is to prefix `New*` so this commit renames the `WorkerClientError`. Initially I thought it would be `NewWorkerClientError()` but looking at the package prefix it seems unneeded, i.e. `clienterrors.New()` already provides enough context it seems and it's the only error we construct. We could consider renaming it to `clienterror` (singular) too but that could be a followup. I would also like to make `clienterror.Error` implement the `error` interface but that should be a followup to make this (mechanical) rename trivial to review.
Sorry for the slow reply, I rebased and pushed now, sorry that I did not see the conflicts earlier. And thanks for the kind offer to do it for me, that is of course always welcome too :) |
mvo5
changed the title
WorkerClientError to clienterrors.NewWorkerClientError to clienterrors.New
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual convention to create new object is to prefix
New*so this commit renames theWorkerClientError. Initially I thought it would beNewWorkerClientError()but looking at the package prefix it seems unneeded, i.e.clienterrors.New()already provides enough context it seems and it's the only error we construct.We could consider renaming it to
clienterror(singular) too but that could be a followup.I would also like to make
clienterror.Errorimplement theerrorinterface but that should be a followup to make this (mechanical) rename trivial to review.Note that the rename was done via
so choosing a different name it "cheap".