Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clienterrors: rename WorkerClientError to clienterrors.New #4143

Closed
wants to merge 1 commit into from

Commits on Jun 21, 2024

  1. clienterrors: rename WorkerClientError to clienterrors.New

    The usual convention to create new object is to prefix `New*` so
    this commit renames the `WorkerClientError`. Initially I thought
    it would be `NewWorkerClientError()` but looking at the package
    prefix it seems unneeded, i.e. `clienterrors.New()` already
    provides enough context it seems and it's the only error we
    construct.
    
    We could consider renaming it to `clienterror` (singular) too
    but that could be a followup.
    
    I would also like to make `clienterror.Error` implement the
    `error` interface but that should be a followup to make this
    (mechanical) rename trivial to review.
    mvo5 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5b6f39f View commit details
    Browse the repository at this point in the history