CI: don't test on EOL F39 and update rpmrepos to 20250115 #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
previously approved these changes
Jan 22, 2025
thozza
force-pushed
the
f39-eol
branch
2 times, most recently
from
b89efb9 to
b43ef2d
Compare
thozza
changed the title
|
Like you said, I ran into the executor problem as well in #4559. I don't know much about the new(ish) worker/executor setup so I couldn't really dig into it quickly. If you need any help though, let me know and I can start digging. |
achilleas-k
changed the title
Replace F39 with F41 Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
The original ref pointed to a commit, which used the plain Fedora 41 Cloud Base images, which don't have any test dependencies installed. Use the latest commit from `main`. Signed-off-by: Tomáš Hozza <[email protected]>
Unfortunately, `which` does not seem to be installed by default on our F41 CI images. Instead of doing the dance with rebuilds, which has been problematic recently, let's not rely on `which` in scripts any more, since we can replace it with the Bash built-in `type` command. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
It turned out that our new F41 CI images have firewalld installed. Make sure that the worker-executor port is opened in firewall, otherwise the worker can't connect to the executor. Signed-off-by: Tomáš Hozza <[email protected]>
thozza
commented
Jan 28, 2025
thozza
requested review from
ondrejbudai,
mvo5,
schuellerf,
supakeen and
tkoscieln
|
Note that the failed edge test cases are NOT blocking the merge and are also failing on other PRs. I reached out to EDGE folks and asked for help with debugging... |
|
LGTM so far, but would wait until @croissanne adresses the unresolved conversation |
achilleas-k
approved these changes
Jan 29, 2025
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20250115.whichto check for executables in our test cases, because it is not available by default on F41 any more.worker-executor.shtest case to opentcp/8001port on the firewall in the executor VM.