Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2]Ardent support #108

Merged
merged 5 commits into from
Jan 25, 2018
Merged

[ROS2]Ardent support #108

merged 5 commits into from
Jan 25, 2018

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Jan 9, 2018

This removes r2b3 in favor of ardent and update the dockerfiles accorndingly.
Holding the merge waiting for a decision to be made on the tags

fixes #107

@ruffsl
Copy link
Member

ruffsl commented Jan 23, 2018

@mikaelarguedas , I like those tags you've added. You can set the version: True in the platform.yaml to fixate the package versions. However, it looks like you've added wildcards to the package list in images.yaml, so the current docker_templates python module would be unable to resolve those.

Do you intend to keep the wildcards, or is this temporary? We could adapt the docker_templates library to accommodate this use case, i.e. expand the list from wildcards and then tag the version for each specific package. Or is the intent to alway pass the wildcard to apt directly to be inferred at build time? I think the expansion of wildcards would be simpler for build auditing purposes and for upstreaming, even if the dockerfiles themselves turnout to be longer.

@mikaelarguedas
Copy link
Contributor Author

@ruffsl Thanks for the feedback.
TL;DR: I think having the expansion of wildcard and population of the dockerfiles with each package and its version would be great, but I don't think it's required for this release.

Do you intend to keep the wildcards, or is this temporary? We could adapt the docker_templates library to accommodate this use case,

Yeah I was wondering the same thing. It's currently a convenience to be able to use the wildcards as these tags / variants are likely to change in the future (as I make them up as I go) and because we don't have "metapackages" associated with them that would stremline the installation process).

I don't think there is a need to pin down versions right now as we don't plan on submitting any of these upstream at the moment and that would allow us to trigger rebuilds for each ardent patch release without having to modify the dockerfiles. So I'd say it would be great in the future but it shouldnt be necessary to spend time on it right now.

@mikaelarguedas mikaelarguedas merged commit 87cf6d7 into master Jan 25, 2018
@mikaelarguedas mikaelarguedas deleted the ardent_support branch January 25, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ROS2] Replace r2b3 with ardent
2 participants