refactor: ingame_logins repository #489
Conversation
7mochi
requested review from
cmyui,
skrungly,
NiceAesth and
tsunyoku
as code owners
|
Will you apply the unset suggestion to all of the currently open PRs or will that be a following PR? Would prefer if it was multiple palletable prs |
|
|
7mochi
force-pushed
the
ingame-logins-repo
branch
from
5dab833
to
f446450
Compare
7mochi
force-pushed
the
ingame-logins-repo
branch
2 times, most recently
from
21f06ff
to
a40f6f1
Compare
|
i think the rest is good |
app/repositories/ingame_logins.py
Outdated
| INSERT INTO ingame_logins (userid, ip, osu_ver, osu_stream, datetime) | ||
| VALUES (:userid, :ip, :osu_ver, :osu_stream, NOW()) | ||
| """ | ||
| params = { |
There was a problem hiding this comment.
ah we should also set dict[str, Any] as the type on each declaration of params because the default behaviour will be to take the types of the initial definition, which will be more specific (less flexible)
There was a problem hiding this comment.
but this should only be set on the initial declaration of params - if it's redefined in the same function ,it should not have the type annotation
mypy will point this out
There was a problem hiding this comment.
u can see it in the other repos from master after #501
cmyui
force-pushed
the
ingame-logins-repo
branch
from
0c11d8d
to
0e0118d
Compare
Describe your changes
Related Issues / Projects
Checklist
make lint)