Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mods to player.last_np #526

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Conversation

minisbett
Copy link
Contributor

@minisbett minisbett commented Sep 25, 2023

Describe your changes

Adds the mods, which are already being parsed from the /np regex, to the player.last_np object.

Related Issues / Projects

Resolves #478

Checklist

  • I've manually tested my code
  • The changes pass pre-commit checks (make lint)
  • The changes follow coding style

@cmyui
Copy link
Member

cmyui commented Sep 25, 2023

player.last_np is typed here as well - needs update

class LastNp(TypedDict):
bmap: Beatmap
mode_vn: int
timeout: float

@cmyui
Copy link
Member

cmyui commented Sep 26, 2023

hmm mypy is not running on this pr - maybe cause it's on another repo? not sure

cc @tsunyoku

@minisbett
Copy link
Contributor Author

player.last_np is typed here as well - needs update

class LastNp(TypedDict):
bmap: Beatmap
mode_vn: int
timeout: float

oh shit

@tsunyoku
Copy link
Contributor

tsunyoku commented Sep 26, 2023

hmm mypy is not running on this pr - maybe cause it's on another repo? not sure

cc @tsunyoku

just checked, you limited the workflow to the push action which is indeed restricted to pushes on any branch in the main repo.

you can copy the rules from the other workflows - adding a pull_request action should fix it (you can still limit to *.py)

@cmyui
Copy link
Member

cmyui commented Sep 26, 2023

adding a pull_request action should fix it

nice let me try ty

app/api/domains/cho.py Show resolved Hide resolved
app/api/domains/cho.py Show resolved Hide resolved
@cmyui
Copy link
Member

cmyui commented Feb 12, 2024

+1 👍🏻

@cmyui cmyui merged commit 3b2c046 into osuAkatsuki:master Feb 12, 2024
4 checks passed
@minisbett minisbett deleted the add-mods-to-np branch February 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mods to beatmap.last_np
4 participants