-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mods to player.last_np #526
Conversation
player.last_np is typed here as well - needs update bancho.py/app/objects/player.py Lines 143 to 146 in 3a62938
|
hmm mypy is not running on this pr - maybe cause it's on another repo? not sure cc @tsunyoku |
oh shit |
just checked, you limited the workflow to the you can copy the rules from the other workflows - adding a |
nice let me try ty |
7ee2789
to
e047f7b
Compare
+1 👍🏻 |
Describe your changes
Adds the mods, which are already being parsed from the /np regex, to the player.last_np object.
Related Issues / Projects
Resolves #478
Checklist
make lint
)