AO3-6764 Add kudo mailer preview #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
commented
Jul 16, 2024
| guest_count = params[:guest_count] || 1 | ||
| user_count = params[:user_count].to_i || 1 | ||
| names = Array.new(user_count) { "User#{Faker::Alphanumeric.alpha(number: 8)}" } | ||
| hash = { "Work_#{work.id}": { guest_count:, names: } } |
There was a problem hiding this comment.
This syntax is new to Ruby 3.1 and the rubocop annotation is a false positive. Adding a space would make a different cop complain. This cop accepts the formatting starting with rubocop 1.24.0, we are on 1.22.3.
| reset_mailer | ||
| end | ||
|
|
||
| Then /^"([^\"]*)" should be emailed$/ do |user| | ||
| Given "a locale with translated emails" do | ||
| language = Language.find_or_create_by(short: "new", name: "New") |
There was a problem hiding this comment.
This is a completely new language and locale to prevent the existing translations from interfering with the tests. Otherwise a test might break when a Phrase export changes a translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6764
Purpose
Add a preview for the kudo mailer. The amount of guest and user kudos is configurable with URL params.
Move the
I18n.with_localecall so that the locale dropdown in the preview works (see #4292 for another PR that did this). Update the locale keys to get rid of thehtml_safecalls.Testing Instructions
See Jira.
References
PR Limit: 6 out of 5
Using reviewer bonus:
#4720
#4736
Credit
Bilka (he/him)