-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement updating an existing healthcare professional #956
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8c11610
to
42f3339
Compare
e3fdfb2
to
cbc827c
Compare
d3b2112
to
f5f53a2
Compare
244aee9
to
0d5d5c3
Compare
a104922
to
ef34e95
Compare
ef34e95
to
09cabef
Compare
2bb1d00
to
f2bb0c9
Compare
@NabbeunNabi for the UX, there's a couple concerns I've got.
|
f19c905
to
9769e15
Compare
@ermish updated. Will add another video with the update to the PR description |
4f87a8d
to
4e1207c
Compare
Loving the updates! Looks like you got all the UX changes in. |
This refactor uses our updated api call to handle error messages from the server
This change updates the card to display per name and take in another prop as well as adds a mutation observor instead of onUpdate. onUpdate causes event bubbling that can affect the functionality of the multiselect. The watch will give the multiselect functionality once the select elements exist in the dom per the mutation observer.
4e1207c
to
94e90b5
Compare
Resolves #795
🔧 What changed
Before there was no way to update an existing healthcare professional in our database. This implements the functionality with updated UI/UX.
📸 Screenshots
Before
Not implemented
After
Firestore before update
-Firestore after update
-Video
edit_existing_hp.mp4
-Video with new input (version 2)
https://github.com/user-attachments/assets/ffe77441-334b-45e5-bda4-2160ecc1ab60
-Removed quick flash with timeout (version 2)
localhost_3000_moderation_edit-healthcare-professional_lbolXh9oxAqW89wZ4FHP.-.Google.Chrome.2025-01-29.20-46-25.mp4
@ermish Version 3 with it looking like part of the card only when editing and not adding a new one.
card_update_2.mp4