Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement updating an existing healthcare professional #956

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NabbeunNabi
Copy link
Contributor

@NabbeunNabi NabbeunNabi commented Jan 8, 2025

Resolves #795

🔧 What changed

Before there was no way to update an existing healthcare professional in our database. This implements the functionality with updated UI/UX.

📸 Screenshots

  • Before

Not implemented

  • After

  • Firestore before update
    image
    image
    image

-Firestore after update
image
image
image
image

-Video

edit_existing_hp.mp4

-Video with new input (version 2)
https://github.com/user-attachments/assets/ffe77441-334b-45e5-bda4-2160ecc1ab60

-Removed quick flash with timeout (version 2)

localhost_3000_moderation_edit-healthcare-professional_lbolXh9oxAqW89wZ4FHP.-.Google.Chrome.2025-01-29.20-46-25.mp4

@ermish Version 3 with it looking like part of the card only when editing and not adding a new one.

card_update_2.mp4

@NabbeunNabi NabbeunNabi self-assigned this Jan 8, 2025
@NabbeunNabi NabbeunNabi added enhancement New feature or request moderation panel labels Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit 94e90b5
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/67a008170089ca00084a7ba0
😎 Deploy Preview https://deploy-preview-956--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabbeunNabi NabbeunNabi changed the title refactor: update function that updates existing healthcare professional feat: implement updating an existing healthcare professional Jan 8, 2025
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 6 times, most recently from 8c11610 to 42f3339 Compare January 16, 2025 01:23
@NabbeunNabi NabbeunNabi reopened this Jan 16, 2025
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 3 times, most recently from e3fdfb2 to cbc827c Compare January 17, 2025 03:33
@NabbeunNabi NabbeunNabi marked this pull request as ready for review January 17, 2025 03:40
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 3 times, most recently from d3b2112 to f5f53a2 Compare January 17, 2025 06:56
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 2 times, most recently from 244aee9 to 0d5d5c3 Compare January 17, 2025 07:04
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 3 times, most recently from a104922 to ef34e95 Compare January 19, 2025 23:49
@NabbeunNabi NabbeunNabi marked this pull request as draft January 20, 2025 11:28
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch from ef34e95 to 09cabef Compare January 20, 2025 23:57
@NabbeunNabi NabbeunNabi marked this pull request as ready for review January 20, 2025 23:57
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 2 times, most recently from 2bb1d00 to f2bb0c9 Compare January 21, 2025 23:37
@ermish
Copy link
Contributor

ermish commented Jan 27, 2025

@NabbeunNabi for the UX, there's a couple concerns I've got.

  • the edit button location to me is confusing. The card feels like nice example rendering to display how their name would look on the card, but the edit and delete buttons should not be in it. Can we move them into a separate container?
  • For the locale selector, the call to action is a bit strange. Am I adding a name per selected locale? How do I know which ones are set? I would recommend we could start with something like an array of name cards for each locale and they can add/remove one. This should work because most people don't have a name in more than 3 languages.

@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 3 times, most recently from f19c905 to 9769e15 Compare January 29, 2025 11:20
@NabbeunNabi
Copy link
Contributor Author

@NabbeunNabi for the UX, there's a couple concerns I've got.

  • the edit button location to me is confusing. The card feels like nice example rendering to display how their name would look on the card, but the edit and delete buttons should not be in it. Can we move them into a separate container?
  • For the locale selector, the call to action is a bit strange. Am I adding a name per selected locale? How do I know which ones are set? I would recommend we could start with something like an array of name cards for each locale and they can add/remove one. This should work because most people don't have a name in more than 3 languages.

@ermish updated. Will add another video with the update to the PR description

@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch 4 times, most recently from 4f87a8d to 4e1207c Compare January 29, 2025 11:45
@ermish
Copy link
Contributor

ermish commented Jan 31, 2025

Loving the updates! Looks like you got all the UX changes in.
One more usability change:
Can you make the fields section attached to the preview card?
It doesn't look like they're the same item.

This refactor uses our updated api call to handle error messages from the server
This change updates the card to display per name and take in another prop as well as adds a mutation observor instead of onUpdate. onUpdate causes event bubbling that can affect the functionality of the multiselect. The watch will give the multiselect functionality once the select elements exist in the dom per the mutation observer.
@NabbeunNabi NabbeunNabi force-pushed the feat/update-existing-healthcare-professional branch from 4e1207c to 94e90b5 Compare February 3, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request moderation panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functionality to Mod Healthcare Form for updating a healthcare professional
4 participants