block_sigmoid + block_tanh - fix test 'test_simple_positive'

outbrain-inc · Jan 11, 2023 · 8cc0ff4 · 8cc0ff4
1 parent 9b055ee
commit 8cc0ff4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/block_sigmoid.rs b/src/block_sigmoid.rs
@@ -152,8 +152,8 @@ mod tests {
         let mut pb = bg.new_port_buffer();
 
         let fb = fb_vec();
-        assert_epsilon!(slearn2(&mut bg, &fb, &mut pb, true), 2.0);
-        assert_epsilon!(slearn2(&mut bg, &fb, &mut pb, true), 2.0); // sigmoid doesn't learn
+        assert_epsilon!(slearn2  (&mut bg, &fb, &mut pb, true), 0.880797);
+        assert_epsilon!(slearn2  (&mut bg, &fb, &mut pb, true), 0.880797); // sigmoid doesn't learn
     }
 
     fn test_simple_negative() {

diff --git a/src/block_tanh.rs b/src/block_tanh.rs
@@ -145,8 +145,8 @@ mod tests {
         let mut pb = bg.new_port_buffer();
 
         let fb = fb_vec();
-        assert_epsilon!(slearn2(&mut bg, &fb, &mut pb, true), 2.0);
-        assert_epsilon!(slearn2(&mut bg, &fb, &mut pb, true), 2.0); // tanh desnt learn
+        assert_epsilon!(slearn2  (&mut bg, &fb, &mut pb, true), 0.9640276);
+        assert_epsilon!(slearn2  (&mut bg, &fb, &mut pb, true), 0.9640276); // tanh doesn't learn
     }
     fn test_simple_negative() {
         let mi = model_instance::ModelInstance::new_empty().unwrap();