fix: Feedback instructions and reminders (Short term solution for issue #569) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feedback 4, our final feedback cycle, is referred to as "final feedback" in code. When mentors are late to submit feedback about their interns a fourth time, we send them an automated email via organizer dashboard that includes wording about their intern's final stipend payment — but that doesn't reflect current Outreachy policies. I've updated this file to include the same wording used on `home/templates/home/email/feedback4-feedback-reminder.txt`. Feedback 4 is still referred to as `final_feedback` in code. We probably shouldn't use `feedback4` yet.
Since our code uses both `final-feedback-instructions.txt` and `final-feedback-reminder.txt` as the templates for automated emails, it doesn't make sense to keep redundant files.
contraexemplo
force-pushed
the
feedback4-reminder
branch
from
ed9d88c
to
6849e6a
Compare
|
Sage Sharp and I discussed #569 today. We agreed to remove the unused, redundant files If you're interested in the bigger context around this issue, I published a longer, more detailed report about it on my blog. |
|
Marked as a draft as I found a couple more issues with our feedback instructions and reminder email templates. Will add more details to #569. |
contraexemplo
changed the title
Upon further inspection, all feedback instructions and reminders were quite inconsistent in the way they informed mentors about our current policies and in the terminology they used to refer to feedback cycles. My proposed edits make them more consistent. Further edits on Feedback 1 template
contraexemplo
force-pushed
the
feedback4-reminder
branch
from
a096015
to
00d1da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed short term solution for issue #569. Feedback 4, our final feedback cycle, is referred to as
final feedbackin code. When mentors are late to submit Feedback 4, we send them an automated email via organizer dashboard that includes wording about their intern's final stipend payment — but that doesn't reflect current Outreachy policies. I've updated this file to include the same wording used onhome/templates/home/email/feedback4-feedback-reminder.txt.