Enhancement: Python 3.12 upgrade #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2024 13:12
2 tasks
ModuleNotFoundError: No module named '_sqlite3' fixed above error on line >>> RUN python manage.py compilemessages
regisb
reviewed
Mar 21, 2024
| @@ -27,15 +27,26 @@ WORKDIR /openedx/discovery | |||
| RUN echo "{}" > /openedx/config.yml | |||
| ENV DISCOVERY_CFG /openedx/config.yml | |||
|
|
|||
| # Install python venv | |||
| RUN python3 -m venv ../venv/ | |||
| # Install pyenv | |||
There was a problem hiding this comment.
Can we inherit FROM the python:3.12-bookworm image instead of installing python manually with pyenv? These steps make the build more complex, and I'd rather not use them if possible at all.
There was a problem hiding this comment.
P.S. this is on my todo list to test out python build using python images. That can be done in a followup PR, in my opinion (once tested).
Why do we want to use bookworm specifically? why not slim?
|
@regisb @DawoudSheraz Tested on my local system and Image building is successful using this branch. |
DawoudSheraz
approved these changes
Mar 27, 2024
=> [minimal 7/19] RUN echo "{}" > /openedx/config.yml 0.2s
=> ERROR [minimal 8/19] RUN git clone https://github.com/pyenv/pyenv /opt/pyenv --branch v2.3.36 --depth 1 0.4s
------
> importing cache manifest from docker.io/overhangio/openedx-discovery:17.0.0-nightly-cache:
------
------
> [minimal 8/19] RUN git clone https://github.com/pyenv/pyenv /opt/pyenv --branch v2.3.36 --depth 1:
0.341 fatal: could not create work tree dir '/opt/pyenv': Permission denied
------
Dockerfile:36
--------------------
34 | ENV PYENV_ROOT /opt/pyenv
35 | # USER root
36 | >>> RUN git clone https://github.com/pyenv/pyenv $PYENV_ROOT --branch v2.3.36 --depth 1
37 | # Install Python
38 | RUN $PYENV_ROOT/bin/pyenv install $PYTHON_VERSION
--------------------
ERROR: failed to solve: process "/bin/sh -c git clone https://github.com/pyenv/pyenv $PYENV_ROOT --branch v2.3.36 --depth 1" did not complete successfully: exit code: 128
|
@Faraz32123 you should be good to merge this for now. We can work on using python image in a followup PR. |
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #62