Merge remote-tracking branch 'origin/master' into nightly

overhangio · Dec 8, 2023 · a4a4fc5 · a4a4fc5
2 parents aa62ada + 084f09e
commit a4a4fc5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/changelog.d/20231208_112710_regis_nightly_auto_build_mfe.md b/changelog.d/20231208_112710_regis_nightly_auto_build_mfe.md
@@ -0,0 +1 @@
+- [Bugfix] Auto-build "mfe" image during `dev/local launch` in nightly. (by @regisb)
diff --git a/tutormfe/plugin.py b/tutormfe/plugin.py
@@ -247,6 +247,10 @@ def _print_mfe_public_hosts(
 def _build_3rd_party_dev_mfes_on_launch(
     image_names: list[str], context_name: t.Literal["local", "dev"]
 ) -> list[str]:
+    if __version_suffix__:
+        # Build mfe image in nightly mode
+        image_names.append("mfe")
+
     for mfe_name, _mfe_attrs in iter_mfes():
         if __version_suffix__ or (
             context_name == "dev" and mfe_name not in CORE_MFE_APPS