-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces MFE_DOCKER_IMAGE_DEV_PREFIX #216
feat: introduces MFE_DOCKER_IMAGE_DEV_PREFIX #216
Conversation
@regisb thoughts? |
I'm not sure I understand. What problem exactly is this PR solving? Please describe your use case precisely, and how this change improves your workflow. |
Yes, this probably deserves a bit more explanation than what I provided above. Scenario 1: when customizing existing MFEs Scenario 2: when creating new MFEs Let me know if any of that makes sense... |
OK I understand. For once, the "right" fix for this is to introduce a new setting: |
Will do, thank you very much! |
@regisb all set, let me know what you think! |
Oops, forgot the changelog... |
MFE_DOCKER_IMAGE_DEV_PREFIX
MFE_DOCKER_IMAGE_DEV_PREFIX
Resolves `Error: Image 'course-about-dev' could not be found`
See this PR for details: overhangio/tutor-mfe#216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @arbrandes what do you think?
I have tested it. LGTM! |
Introduces a
MFE_DOCKER_IMAGE_DEV_PREFIX
setting to customize dev MFE image docker repos. See discussion below for the benefits.