Remove unnecessary dynamic casts

[eduar-hte]

what

This short PR removes a number of dynamic_cast casts in the codebase, some of which are performed twice and could be rewritten to perform the runtime cast only once.

why

dynamic_cast is performed at runtime and requires inspecting the object's RTTI information to perform the cast. Executing it more than once incurs a bit of a performance cost that could be avoided by rewriting the code snippet. Additionally, the rewritten code is shorter and thus easier to read and maintain.

For example (from src/rule_with_actions.cc):

                    } else if (dynamic_cast<actions::Severity *>(a)) {
                        m_severity = dynamic_cast<actions::Severity *>(a);

can be rewritten as:

                    } else if (auto sa = dynamic_cast<actions::Severity *>(a)) {
                        m_severity = sa;

misc

This is part of a series of PRs to improve performance of the library (2/n). Previous: #3164

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

[airween]

Thanks - I tried to measure the performance with this patch, but didn't get any significant difference (but it might improve it in real environments).

Never mind, the patch makes the code more visible indeed, going to merge.

[airween]

LGTM - thanks.

[eduar-hte]

Thanks - I tried to measure the performance with this patch, but didn't get any significant difference (but it might improve it in real environments).

That's right, these changes are not going to make a noticeable difference, but the goal is to shave off as much as possible over time.