Remove several string copies and unnecessary heap allocations #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate a new one to transform it - Make functions inline to improve performance - Introduced helper method toCaseHelper to remove code duplication
- Introduced helper method addVariableOrigin to reduce code duplication.
…ential buffer overflow
eduar-hte
force-pushed
the
remove-copies
branch
from
b77fe4e
to
cc0f893
Compare
eduar-hte
changed the title
- Other minor changes reported by sonarcloud
eduar-hte
force-pushed
the
remove-copies
branch
from
8ac526e
to
77adb57
Compare
|
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
src/utils/string.*by moving the definition of these functions into the header file.why
The unnecessary heap allocations and copies take time and contribute to heap fragmentation (which also reduces performance over time).
misc
This is part of a series of PRs to improve performance of the library (3/n). Previous: #3218