Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove several string copies and unnecessary heap allocations #3222

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Remove several string copies and unnecessary heap allocations #3222

merged 6 commits into from
Aug 13, 2024

Commits on Aug 9, 2024

  1. toupper/tolower is already receiving a copy, so it doesn't need to cr… 

    …eate a new one to transform it

- Make functions inline to improve performance
- Introduced helper method toCaseHelper to remove code duplication
    @eduar-hte
    eduar-hte committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    bb07de9 View commit details
    Browse the repository at this point in the history

  2. Avoid creating a new std::string on the heap to create VariableValue 

    - Introduced helper method addVariableOrigin to reduce code duplication.
    @eduar-hte
    eduar-hte committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f8dd09f View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary copies

    @eduar-hte
    eduar-hte committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1534ee2 View commit details
    Browse the repository at this point in the history

  4. Inline string functions

    @eduar-hte
    eduar-hte committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8b17f36 View commit details
    Browse the repository at this point in the history

  5. Removed unused overload of dash_if_empty that sonarcloud flags as pot… 

    …ential buffer overflow
    @eduar-hte
    eduar-hte committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cc0f893 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Avoid std::string copy in ssplit argument 

    - Other minor changes reported by sonarcloud
    @eduar-hte
    eduar-hte committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    77adb57 View commit details
    Browse the repository at this point in the history