Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔬 experiment to create CSV in CF function #3613

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

🔬 experiment to create CSV in CF function #3613

wants to merge 3 commits into from
+1,042 −74

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented May 16, 2024

This is an experiment to serve the input table for a chart rendered as CSV from a CF function

@owidbot
Copy link
Contributor

owidbot commented May 16, 2024 •
edited
Loading

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-server-side-csv

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-31 07:59:25 UTC
Execution time: 1.22 seconds

larsyencken
larsyencken reviewed May 22, 2024
View reviewed changes
functions/grapher/csv/[slug].ts Outdated
async ({ params: { slug } }, { searchParams: _ }, env) =>
fetchCsvForGrapher(slug, env)
)
.all("*", () => error(404, "Route not defined"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests to me that either the filename doesn't matter, or the routing (nearly) doesn't matter.

@github-actions GitHub Actions
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jun 12, 2024
@github-actions github-actions bot closed this Jun 16, 2024
@danyx23 danyx23 reopened this Jun 17, 2024
@danyx23 danyx23 added pinned and removed stale labels Jun 17, 2024
@danyx23 danyx23 mentioned this pull request Jul 24, 2024
Draft
@danyx23 Graphite App
Copy link
Contributor Author

danyx23 commented Jul 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@danyx23 danyx23 force-pushed the server-side-csv branch 2 times, most recently from 1f9008e to 4549ceb Compare August 12, 2024 10:42
@danyx23 danyx23 changed the base branch from master to multiembedder-use-config-api August 26, 2024 20:46
This was referenced Aug 26, 2024
Merged
Merged
Merged
Merged
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 4f6ed11 to 8e9dbef Compare August 28, 2024 15:50
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch 2 times, most recently from caecd68 to d728828 Compare September 10, 2024 11:48
@danyx23 danyx23 changed the base branch from multiembedder-use-config-api to graphite-base/3613 September 10, 2024 12:01
@danyx23 danyx23 changed the base branch from graphite-base/3613 to master September 10, 2024 12:01
@danyx23 danyx23 force-pushed the server-side-csv branch 2 times, most recently from 07a1018 to c1fdfd7 Compare September 12, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsyencken larsyencken larsyencken left review comments

Assignees

@danyx23 danyx23

Labels
pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danyx23 @owidbot @larsyencken