-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use grapher config from API instead of from HTML in multiembedder #3884
Merged
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 10:17
265637f
to
91f193d
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 21, 2024 10:17
7ff4c04
to
718d193
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 11:03
91f193d
to
41b9260
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 21, 2024 11:03
718d193
to
9575cd4
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 12:54
41b9260
to
1dd7bdb
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 21, 2024 12:54
9575cd4
to
df54d29
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 15:09
1dd7bdb
to
019831b
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 21, 2024 15:09
df54d29
to
31783c0
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 15:17
019831b
to
b96dde4
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 21, 2024 15:18
31783c0
to
4969cea
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 15:53
b96dde4
to
9490433
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 22, 2024 15:53
4969cea
to
935fde8
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 15:56
9490433
to
6d5c3bc
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 22, 2024 15:56
935fde8
to
daf3747
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 17:12
6d5c3bc
to
b6d10f1
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 22, 2024 17:12
daf3747
to
efe49d6
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 23, 2024 11:21
b6d10f1
to
6189190
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 23, 2024 11:21
efe49d6
to
a6efc86
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 26, 2024 20:46
6189190
to
845c2ab
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
August 26, 2024 20:46
a6efc86
to
4f6ed11
Compare
This was referenced Aug 26, 2024
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 28, 2024 15:50
845c2ab
to
26e490c
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 9, 2024 14:45
940738b
to
0df5bff
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 9, 2024 14:46
e5338b6
to
8f4418c
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 07:59
0df5bff
to
2a74086
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 07:59
8f4418c
to
6ea8ff0
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 08:06
2a74086
to
fa93186
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 08:06
6ea8ff0
to
14065aa
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 09:56
fa93186
to
8152321
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 09:56
14065aa
to
25404f1
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:24
8152321
to
2163513
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:24
25404f1
to
53ab64b
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:35
2163513
to
dd56e2b
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:35
53ab64b
to
35deed4
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:55
dd56e2b
to
eb1de29
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:56
35deed4
to
4c94b5a
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 11:15
eb1de29
to
380b1f5
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:16
4c94b5a
to
18dd056
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
2 times, most recently
from
September 10, 2024 11:31
02cf775
to
2689b72
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:31
18dd056
to
868a5f7
Compare
danyx23
changed the base branch from
render-thumbnails-by-uuid
to
graphite-base/3884
September 10, 2024 11:47
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:48
868a5f7
to
caecd68
Compare
Also adds two new mockSiteRouter routes so that in local dev we can fetch grapher configs from the DB instead of R2 via the admin API
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:48
caecd68
to
d728828
Compare
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the multi-embedder from using the chart config in the HTML file to the explicit grapher API.
The current (draft) version just uses the same url as the request came in on but that means that for local dev you need to have baked pages to use port :8788. It's probably nicer to have an explicit "grapher api url" setting that defaults to the same as the main page for prod but can be set differently for local dev or staging