Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdd: fetch variable-level config by uuid #3922

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Sep 3, 2024

This is currently quite painful to test -- sorry!

During the bake, a variableIdToGrapherConfigMap is written into the HTML.
It maps primary variable IDs to their respective grapherConfigIdAdmin ?? grapherConfigIdETL ?? null.

If such a UUID is present, then the config is fetched at runtime.
It is currently a bit hard to make grapher wait for this grapher config to arrive - it displays an empty screen during the loading, rather than a loading indicator of some sort.
We can tweak this later on, but we don't want grapher to render before the config override has been fetched, otherwise we're flash-rendering twice with different FAUST.

@marcelgerber marcelgerber changed the base branch from master to fetch-grapher-config-by-uuid September 3, 2024 17:05
@sophiamersmann sophiamersmann force-pushed the fetch-grapher-config-by-uuid branch 6 times, most recently from 6bc713d to 1aae0c6 Compare September 5, 2024 07:42
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch 3 times, most recently from 41c76dc to 0b7eadc Compare September 5, 2024 12:31
@danyx23 danyx23 changed the base branch from fetch-grapher-config-by-uuid to multiembedder-use-config-api September 5, 2024 18:37
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch 2 times, most recently from caecd68 to d728828 Compare September 10, 2024 11:48
@danyx23 danyx23 changed the base branch from multiembedder-use-config-api to graphite-base/3922 September 10, 2024 12:01
@danyx23 danyx23 changed the base branch from graphite-base/3922 to master September 10, 2024 12:03
Copy link
Contributor

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 10:04 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 10:04 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit 8b53f96 into master Sep 10, 2024
18 of 20 checks passed
@danyx23 danyx23 deleted the mdd-fetch-config-by-uuid branch September 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants