TDK housekeeping stabilization (do not merge before #50) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
reviewed
Apr 18, 2023
| openIDConnect: 'openIDConnect', | ||
| basicAuth: 'basicAuth', | ||
| } as const; | ||
| kopano: 'kopano', |
- add new 070-user-group-search-and-share test and docs from the koko test paper - add new groups api and add those to the tdk client - add several es-lint rules to the default config and apply those
- add new 080-create-space test and docs based on the koko test paper - add client version guard to protect the test from unsupported client versions - rename the api tdk package to endpoints, to not have a api.api route which is needed for ocis - add eslint rule to have linebreaks between class members - stop using k6 response json method - add client endpoints for application - add client endpoints for drive - add client endpoints for role
- fix static space creation count
- add new 090-add-remove-user-share test and docs based on the koko test paper - add new share delete client endpoint
- add koko 030-search-for-filename test and docs - introduce versionSupported helper and use it instead of plain conditions - add tag search - use og jsonpath instead of jsonpath-plus and adjust related helpers - introduce tag client endpoints - introduce systemtags and systemtags_relations endpoints - introduce libregraph org tags endpoints
this enhancement cleans up the tdk/client endpoint structure and introduces a naming schema which applies to all compatible clouds. beside the client refactoring it updates all related tests to use that changed api.
cleanup, rename and structure available and used utils
integrate vitest, make it possible to run tests on monorepo level via turbo and provide unit tests for the utils package
mote Platform const out of the client to prevent circular imports
cleanup auth adapters and rename the oidc adapter to kopano
remove not needed semicolons
butonic
reviewed
Apr 18, 2023
|
|
||
| import { Authenticator, Token } from './auth' | ||
|
|
||
| export class Kopano implements Authenticator { |
There was a problem hiding this comment.
well, or stick withOpenIDConnect with config options for the login url, username and passwond params ... ? that might be enough for a generic openidconnect auth
There was a problem hiding this comment.
wont't work :( i can have a look in the next oidc pr
cleanup previous pr rebase
fschade
force-pushed
the
cleanup-ocis-koko
branch
from
53e981b
to
303c7c5
Compare
butonic
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the TDK developments happened at the same moment as the test development and it was not 100% clear how to structure and organize (naming, hierarchies, package grouping, ...) the DK during the development cycle.
We now have the koko tests in place and my understanding is good enough to structure the ZDK package.
This Pr will contain those improvements and will contain:
this PR is a important part for 2.0.0-rc.4